Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CompatHelper: bump compat for Trixi to 0.6 for package LibTrixi.jl, (keep existing compat) #158

Merged

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Jan 9, 2024

This pull request changes the compat entry for the Trixi package from 0.5.29 to 0.5.29, 0.6 for package LibTrixi.jl.
This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.

@github-actions github-actions bot force-pushed the compathelper/new_version/2024-01-09-00-13-17-136-02904521495 branch from 07bd1c3 to c14b9a0 Compare January 9, 2024 00:13
@benegee
Copy link
Collaborator

benegee commented Jan 9, 2024

Perfectly right!

Can we somehow prevent it from deleting our comment?

Or is it save to delete the comment, now that CompatHelper takes care of versions?
@sloede

@sloede
Copy link
Member

sloede commented Jan 9, 2024

imo it's ok to lose the comment

@benegee benegee merged commit 2eef86f into main Jan 9, 2024
@benegee benegee deleted the compathelper/new_version/2024-01-09-00-13-17-136-02904521495 branch January 9, 2024 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants