Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

P4estMesh: Naming of symbolic indices #777

Closed
ranocha opened this issue Aug 12, 2021 · 7 comments · Fixed by #784
Closed

P4estMesh: Naming of symbolic indices #777

ranocha opened this issue Aug 12, 2021 · 7 comments · Fixed by #784

Comments

@ranocha
Copy link
Member

ranocha commented Aug 12, 2021

@sloede in #767 (comment):

I am not fully happy with the naming of the symbolic indices. I don't like the asymmetries between :one and :end or :i and :i_backwards, respectively. Maybe we use :begin instead of :one (or :first/:last)? :i_forwards instead of :i (or :forwards/:backwards)?

CC @efaulhaber

@efaulhaber
Copy link
Member

:forwards or :backwards would only work in 2D, as there are two surface indices in 3D.
I'm okay with the other suggestions if you prefer these.

@ranocha
Copy link
Member Author

ranocha commented Aug 13, 2021

@sloede: I'm also okay with

  • :one::begin
  • :i:i_forwards
  • :j:j_forwards

@sloede
Copy link
Member

sloede commented Aug 13, 2021

If I understand you correctly, this is the proposal on the table:

  • :begin and :end to indicate fixed indices
  • :i_forwards, :j_forwards to indicate incrementing indices
  • :i_backwards, :j_backwards to indicate incrementing indices

Incidentally, is it forwards/backwards or should it be forward/backward?

@ranocha
Copy link
Member Author

ranocha commented Aug 13, 2021

If I understand you correctly, this is the proposal on the table:

Yes

@ranocha
Copy link
Member Author

ranocha commented Aug 13, 2021

Incidentally, is it forwards/backwards or should it be forward/backward?

Both is okay for me - native speakers?

@andrewwinters5000
Copy link
Member

Incidentally, is it forwards/backwards or should it be forward/backward?

Both is okay for me - native speakers?

forward/backward sounds better to my ear

@sloede
Copy link
Member

sloede commented Aug 13, 2021

OK, so the result is

  • :begin and :end to indicate fixed indices
  • :i_forward, :j_forward to indicate incrementing indices
  • :i_backward, :j_backward to indicate decrementing indices

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants