Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decide whether the AMR callback should use the number of total or accepted steps #770

Closed
Tracked by #720
ranocha opened this issue Aug 6, 2021 · 4 comments · Fixed by #797
Closed
Tracked by #720

Decide whether the AMR callback should use the number of total or accepted steps #770

ranocha opened this issue Aug 6, 2021 · 4 comments · Fixed by #797
Assignees

Comments

@ranocha
Copy link
Member

ranocha commented Aug 6, 2021

See #771, #759, #769, #19

@ranocha
Copy link
Member Author

ranocha commented Aug 16, 2021

@sloede?

@sloede
Copy link
Member

sloede commented Aug 16, 2021

I'd say to use the number of accepted steps. Why?

  1. Principle of least astonishment (see also Weird screen output behaviour: alive and analyse "forgotten"?  #759)
  2. AMR is essentially a performance optimization: Given the solution changes over time, adapt the mesh accordingly. Since each discarded time step does not change the solution, it should not be counted towards the "time" between two adaptations.

But maybe I forget something, so I'd like to get the opinion of @gregorgassner or @amrueda on this, who use AMR more frequently.

@ranocha
Copy link
Member Author

ranocha commented Aug 16, 2021

I'd say to use the number of accepted steps

I think that, too. It just requires a bit of work and manual checking since the results of at least one elixir will change slightly

@amrueda
Copy link
Contributor

amrueda commented Aug 17, 2021

I agree, AMR should use the number of accepted steps, as the solution does not change in the discarded steps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants