Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin doesn't support parallel compilation #358

Closed
henri-tremblay opened this issue Oct 9, 2024 · 5 comments
Closed

Plugin doesn't support parallel compilation #358

henri-tremblay opened this issue Oct 9, 2024 · 5 comments
Assignees
Milestone

Comments

@henri-tremblay
Copy link

Is your feature request related to a problem? Please describe.

We want to build using Maven param 1.0C. But this plugin doesn't support threading.

Describe the solution you'd like

If it does support threading, the goal should be annotated to mention it. If not, the code should be fixed to support it. Since we have seen the plugin crash in parallel, some code needs to be fixed.

Describe alternatives you've considered

Run the report in a separate build that doesn't run in parall.

Additional context

Tested on 2.9.4 with -T 1.0C and about 12 modules. Java 21 and Maven 3.9.9.

@bischoffdev
Copy link
Collaborator

Version 2.9.4 is quite outdated. The newest one is 3.8.1. Have you tried it with this one?

@henri-tremblay
Copy link
Author

Indeed. I missed that the plugin was renamed. But trying with 3.8.1. However, you still have the threading warning. If it's supported, you should do @Mojo(name = "reporting", requiresProject = false, threadSafe = true). Looking quickly at the code in the mojo, it seems fine.

@bischoffdev bischoffdev added this to the 3.8.2 milestone Oct 16, 2024
@bischoffdev bischoffdev modified the milestones: 3.8.2, 3.8.3 Nov 4, 2024
@bischoffdev
Copy link
Collaborator

bischoffdev commented Nov 5, 2024

Implemented for 3.9.0

@bischoffdev
Copy link
Collaborator

Released

@henri-tremblay
Copy link
Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants