[PROTON] Drop hip_ostream_ops.h in roctracer headers #3989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This header contains a bunch of `operator<<` definitions for print effectively. We don't use them. It's not good to touch public headers but the problem is it uses `__locale_struct` which is missing on macOS and breaks builds.
antiagainst
changed the title
ThomasRaoux
approved these changes
May 24, 2024
antiagainst
added a commit
to antiagainst/triton
that referenced
this pull request
Nov 6, 2024
This header contains a bunch of `operator<<` definitions for print effectively. We don't use them. It's not good to touch public headers but the problem is it uses `__locale_struct` which is missing on macOS and breaks builds.
antiagainst
added a commit
that referenced
this pull request
Nov 6, 2024
This pulls in some new symbols so we don't need to use hardcoded numbers later. This cherry-picks #3989 again to fix macOS builds.
Luosuu
pushed a commit
to Luosuu/triton
that referenced
this pull request
Nov 13, 2024
This pulls in some new symbols so we don't need to use hardcoded numbers later. This cherry-picks triton-lang#3989 again to fix macOS builds.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This header contains a bunch of
operator<<definitions for print effectively. We don't use them. It's not good to touch public headers but the problem is it uses__locale_structwhich is missing on macOS and breaks builds.