Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROCM Support #252

Closed
7 of 11 tasks
micmelesse opened this issue Aug 31, 2021 · 3 comments
Closed
7 of 11 tasks

ROCM Support #252

micmelesse opened this issue Aug 31, 2021 · 3 comments

Comments

@micmelesse
Copy link
Contributor

micmelesse commented Aug 31, 2021

This is just an issue to track the progress of rocm support.

  • Create first pr with empty kernel (uses hipify)
  • upgrade rocm to work as its own module (without hipify)
  • add support for load and store operators
  • add support for an element wise kernel
  • add support for addition and subtraction kernel
  • add support for multiplication kernel
  • add support for matmul kernel
  • add support for softmax kernel
  • add support for conv kernel
  • add support for remaining kernels
  • exp, log, sin, cos
  • add amd intrinsic support to improve performance
@ptillet
Copy link
Collaborator

ptillet commented Sep 1, 2021

Great idea!

I'm optimistic that just getting test_language.py to pass will be enough for the 4 last tasks to "just work". That said, we should also extend test_language.py as needed :) Note that there is a new test_dot unit test that will make it easier to get matmul working https://github.com/openai/triton/blob/master/python/test/test_language.py#L437

@weixingzhang
Copy link

@micmelesse Great to see ROCm support. What is the plan to support matrix core in MI100? Or is it already supported?

@micmelesse
Copy link
Contributor Author

See #1073

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants