Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reuse-http-port flag is integer and not boolean #6481

Closed
VictorM-PS opened this issue Oct 25, 2023 · 2 comments
Closed

reuse-http-port flag is integer and not boolean #6481

VictorM-PS opened this issue Oct 25, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@VictorM-PS
Copy link

Description
The command feature reuse-http-port to merge several triton servers in a single port is indicated boolean in the help flag, however it is actually implemented as integer.

Triton Information
What version of Triton are you using?
23.04

Are you using the Triton container or did you build it yourself?
Triton container with fastertransformer_backend.

To Reproduce

root@ddf7471aa162:/workspace# /opt/tritonserver/bin/tritonserver --allow-http true --model-repository=./models/ner-model/  --load-model=*  --allow-http true --http-port 5023 --reuse-http-port true
terminate called after throwing an instance of 'std::invalid_argument'
  what():  stoi
Aborted (core dumped)

When running it with 1:

root@ddf7471aa162:/workspace# /opt/tritonserver/bin/tritonserver --allow-http true --model-repository=./models/ner-model/  --load-model=*  --allow-http true --http-port 5023 --reuse-http-port=1
I1025 14:02:19.135604 307 pinned_memory_manager.cc:240] Pinned memory pool is created at '0x7fa262000000' with size 268435456
I1025 14:02:19.139103 307 cuda_memory_manager.cc:105] CUDA memory pool is created on device 0 with size 67108864
...

Your test files cover it with the 1 flag but -h documentation is wrong/not clear as it indicates boolean true/false.

Expected behavior
The command line should execute with --reuse-http-port true.

@VictorM-PS VictorM-PS changed the title reuse-http-port Flag is integer and not boolean reuse-http-port flag is integer and not boolean Oct 25, 2023
@dyastremsky dyastremsky added the bug Something isn't working label Oct 25, 2023
@dyastremsky
Copy link
Contributor

Thank you for catching and reporting this bug, as well as detailing how our test files cover it. We have filed a ticket (DLIS-5697) and will fix this.

@dyastremsky
Copy link
Contributor

Thanks for letting us know about this! Closed with #6511.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

No branches or pull requests

4 participants