From 0df1fe7807e297235424e4743618973b9a30ff67 Mon Sep 17 00:00:00 2001
From: Katherine Yang <80359429+jbkyang-nvi@users.noreply.github.com>
Date: Thu, 30 May 2024 15:36:33 -0700
Subject: [PATCH] docs: Add default template that diverts to sub templates
 (#7306)

This PR fixes this known github issue where multiple PR templates is not supported in Github.
It is an add on to PR# 7290
---
 ...pull_request_template_internal_contrib.md} |  0
 .github/pull_request_template.md              | 13 +++++++++
 qa/common/check_copyright.py                  | 29 ++++++++++---------
 3 files changed, 28 insertions(+), 14 deletions(-)
 rename .github/PULL_REQUEST_TEMPLATE/{pull_request_template.md => pull_request_template_internal_contrib.md} (100%)
 create mode 100644 .github/pull_request_template.md

diff --git a/.github/PULL_REQUEST_TEMPLATE/pull_request_template.md b/.github/PULL_REQUEST_TEMPLATE/pull_request_template_internal_contrib.md
similarity index 100%
rename from .github/PULL_REQUEST_TEMPLATE/pull_request_template.md
rename to .github/PULL_REQUEST_TEMPLATE/pull_request_template_internal_contrib.md
diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md
new file mode 100644
index 0000000000..0787dcbc60
--- /dev/null
+++ b/.github/pull_request_template.md
@@ -0,0 +1,13 @@
+Thanks for submitting a PR to Triton!
+Please go the the `Preview` tab above this description box and select the appropriate sub-template:
+
+* [PR description template for Triton Engineers](?expand=1&template=pull_request_template_internal_contrib.md)
+* [PR description template for External Contributors](?expand=1&template=pull_request_template_external_contrib.md)
+
+If you already created the PR, please replace this message with one of
+* [External contribution template](https://raw.githubusercontent.com/triton-inference-server/server/main/.github/PULL_REQUEST_TEMPLATE/pull_request_template_external_contrib.md)
+* [Internal contribution template](https://raw.githubusercontent.com/triton-inference-server/server/main/.github/PULL_REQUEST_TEMPLATE/pull_request_template_internal_contrib.md)
+
+and fill it out.
+
+
diff --git a/qa/common/check_copyright.py b/qa/common/check_copyright.py
index b4247257c8..8aea78e9fd 100755
--- a/qa/common/check_copyright.py
+++ b/qa/common/check_copyright.py
@@ -33,19 +33,20 @@
 
 FLAGS = None
 SKIP_EXTS = (
-    "jpeg",
-    "jpg",
-    "pgm",
-    "png",
-    "log",
-    "preprocessed",
-    "jmx",
-    "gz",
-    "json",
-    "pdf",
-    "so",
-    "onnx",
-    "svg",
+    ".jpeg",
+    ".jpg",
+    ".pgm",
+    ".png",
+    ".log",
+    ".preprocessed",
+    ".jmx",
+    ".gz",
+    ".json",
+    ".pdf",
+    ".so",
+    ".onnx",
+    ".svg",
+    "pull_request_template.md",
 )
 REPO_PATH_FROM_THIS_FILE = "../.."
 SKIP_PATHS = (
@@ -130,7 +131,7 @@ def visit(path):
         print("visiting " + path)
 
     for skip in SKIP_EXTS:
-        if path.endswith("." + skip):
+        if path.endswith(skip):
             if FLAGS.verbose:
                 print("skipping due to extension: " + path)
             return True