Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add wrapper div to ul.suggestions to expand customization #27

Closed
katydecorah opened this issue Mar 21, 2019 · 1 comment · Fixed by #28
Closed

add wrapper div to ul.suggestions to expand customization #27

katydecorah opened this issue Mar 21, 2019 · 1 comment · Fixed by #28

Comments

@katydecorah
Copy link
Collaborator

For mapbox-gl-geocoder, we'd like to append a link to the results so that users can submit search feedback. This is a little tricky right now because if we append this element to ul.suggestions, it'll get cleared out as the user is typing. Given that ul.suggestions is best absolutely positioned, it's difficult to get this new element positioned where we want it (just below ul.suggestions).

@tristen what do you think about a wrapper div for ul.suggestions? From my testing it should be a fairly quick add - I'd be happy to make this PR. Also open to other suggestions!

cc @scottsfarley93

@tristen
Copy link
Owner

tristen commented Mar 21, 2019

@katydecorah 👍sounds good to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants