From 159832962ffcb96a0a5ab4706d407e24b9ddd2fe Mon Sep 17 00:00:00 2001 From: "Mateusz \"Serafin\" Gajewski" Date: Thu, 28 Mar 2024 16:11:39 +0100 Subject: [PATCH] Always use G1GC for product tests --- testing/trino-product-tests-launcher/pom.xml | 3 +-- .../java/io/trino/tests/product/launcher/cli/TestRun.java | 4 ---- .../conf/environment/multinode/multinode-master-jvm.config | 1 - .../conf/environment/multinode/multinode-worker-jvm.config | 1 - 4 files changed, 1 insertion(+), 8 deletions(-) diff --git a/testing/trino-product-tests-launcher/pom.xml b/testing/trino-product-tests-launcher/pom.xml index c8babaa54568..bc70b11bf788 100644 --- a/testing/trino-product-tests-launcher/pom.xml +++ b/testing/trino-product-tests-launcher/pom.xml @@ -279,8 +279,7 @@ org.skife.maven really-executable-jar-maven-plugin - - -Xmx256m -XX:+UseParallelGC -XX:MinHeapFreeRatio=10 -XX:MaxHeapFreeRatio=50 + -Xmx256m executable diff --git a/testing/trino-product-tests-launcher/src/main/java/io/trino/tests/product/launcher/cli/TestRun.java b/testing/trino-product-tests-launcher/src/main/java/io/trino/tests/product/launcher/cli/TestRun.java index 46d9eada6690..aaa5dfb070f5 100644 --- a/testing/trino-product-tests-launcher/src/main/java/io/trino/tests/product/launcher/cli/TestRun.java +++ b/testing/trino-product-tests-launcher/src/main/java/io/trino/tests/product/launcher/cli/TestRun.java @@ -351,10 +351,6 @@ private Environment getEnvironment() .add( jdkProvider.getJavaCommand(), "-Xmx1g", - // Force Parallel GC to ensure MaxHeapFreeRatio is respected - "-XX:+UseParallelGC", - "-XX:MinHeapFreeRatio=10", - "-XX:MaxHeapFreeRatio=50", "-Djava.util.logging.config.file=/docker/presto-product-tests/conf/tempto/logging.properties", "-Duser.timezone=Asia/Kathmandu", // Tempto has progress logging built in diff --git a/testing/trino-product-tests-launcher/src/main/resources/docker/presto-product-tests/conf/environment/multinode/multinode-master-jvm.config b/testing/trino-product-tests-launcher/src/main/resources/docker/presto-product-tests/conf/environment/multinode/multinode-master-jvm.config index 6f8e19ea1588..d453ba01a257 100644 --- a/testing/trino-product-tests-launcher/src/main/resources/docker/presto-product-tests/conf/environment/multinode/multinode-master-jvm.config +++ b/testing/trino-product-tests-launcher/src/main/resources/docker/presto-product-tests/conf/environment/multinode/multinode-master-jvm.config @@ -1,7 +1,6 @@ -server # coordinator is not a worker -Xmx1G --XX:+UseParallelGC -XX:+ExitOnOutOfMemoryError -XX:+HeapDumpOnOutOfMemoryError -XX:-OmitStackTraceInFastThrow diff --git a/testing/trino-product-tests-launcher/src/main/resources/docker/presto-product-tests/conf/environment/multinode/multinode-worker-jvm.config b/testing/trino-product-tests-launcher/src/main/resources/docker/presto-product-tests/conf/environment/multinode/multinode-worker-jvm.config index a4105781fee3..abaa6556167c 100644 --- a/testing/trino-product-tests-launcher/src/main/resources/docker/presto-product-tests/conf/environment/multinode/multinode-worker-jvm.config +++ b/testing/trino-product-tests-launcher/src/main/resources/docker/presto-product-tests/conf/environment/multinode/multinode-worker-jvm.config @@ -1,6 +1,5 @@ -server -Xmx2G --XX:+UseParallelGC -XX:+ExitOnOutOfMemoryError -XX:+HeapDumpOnOutOfMemoryError -XX:-OmitStackTraceInFastThrow