From be9067931202aed4b1fc3b22c255092dcbfa36c6 Mon Sep 17 00:00:00 2001 From: Piotr Findeisen Date: Wed, 9 Aug 2023 17:16:39 +0200 Subject: [PATCH] Remove redundant QualifiedTablePrefix.matches checks The case where table name is present is handled earlier in the method (`prefix.asQualifiedObjectName().isPresent()` check). The connector is asked to list entities for given schema (or all entities if schema is `Optional.empty`), thus subsequent check for `prefix.matches` was redundant. --- .../src/main/java/io/trino/metadata/MetadataManager.java | 3 --- 1 file changed, 3 deletions(-) diff --git a/core/trino-main/src/main/java/io/trino/metadata/MetadataManager.java b/core/trino-main/src/main/java/io/trino/metadata/MetadataManager.java index 4f88f3d7b4b7..50017c6d65be 100644 --- a/core/trino-main/src/main/java/io/trino/metadata/MetadataManager.java +++ b/core/trino-main/src/main/java/io/trino/metadata/MetadataManager.java @@ -529,7 +529,6 @@ public List listTables(Session session, QualifiedTablePrefi metadata.listTables(connectorSession, prefix.getSchemaName()).stream() .map(convertFromSchemaTableName(prefix.getCatalogName())) .filter(table -> !isExternalInformationSchema(catalogHandle, table.getSchemaName())) - .filter(prefix::matches) .forEach(tables::add); } } @@ -1186,7 +1185,6 @@ public List listViews(Session session, QualifiedTablePrefix metadata.listViews(connectorSession, prefix.getSchemaName()).stream() .map(convertFromSchemaTableName(prefix.getCatalogName())) .filter(view -> !isExternalInformationSchema(catalogHandle, view.getSchemaName())) - .filter(prefix::matches) .forEach(views::add); } } @@ -1420,7 +1418,6 @@ public List listMaterializedViews(Session session, Qualifie metadata.listMaterializedViews(connectorSession, prefix.getSchemaName()).stream() .map(convertFromSchemaTableName(prefix.getCatalogName())) .filter(materializedView -> !isExternalInformationSchema(catalogHandle, materializedView.getSchemaName())) - .filter(prefix::matches) .forEach(materializedViews::add); } }