From 4bf354da31481ed95f4a09f85353e4d9f3da2721 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jan=20Wa=C5=9B?= Date: Fri, 7 Jul 2023 09:01:17 +0200 Subject: [PATCH] Fix updating PR comments from tests with secrets workflow Don't use `always()` in step condition with additional predicates, because it ignores other predicates. --- .github/actions/update-check/action.yml | 2 +- .github/workflows/ci.yml | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/.github/actions/update-check/action.yml b/.github/actions/update-check/action.yml index 08712d671db6..3bce2aacbe97 100644 --- a/.github/actions/update-check/action.yml +++ b/.github/actions/update-check/action.yml @@ -25,7 +25,7 @@ runs: steps: - uses: actions/github-script@v6 id: update-check-run - if: always() && inputs.check_name != '' && inputs.conclusion != '' + if: inputs.check_name != '' && inputs.conclusion != '' env: number: ${{ inputs.pull_request_number }} check_name: ${{ inputs.check_name }} diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index feb74e06717d..d7399a208af6 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -533,7 +533,6 @@ jobs: - name: Update PR check uses: ./.github/actions/update-check if: >- - always() && github.event_name == 'repository_dispatch' && github.event.client_payload.slash_command.args.named.sha != '' && github.event.client_payload.pull_request.head.sha == github.event.client_payload.slash_command.args.named.sha