Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve and add JavaDocs related to Materialized Views #17443

Merged
merged 1 commit into from
May 11, 2023

Conversation

huberty89
Copy link
Contributor

Description

Some JavaDoc updates to be more verbose so it will be easier to understand what to expect from specific method

Release notes

(x) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text:

# Section
* Fix some things. ({issue}`issuenumber`)

@cla-bot cla-bot bot added the cla-signed label May 10, 2023
@huberty89 huberty89 requested review from findepi and martint May 10, 2023 14:53
@huberty89 huberty89 force-pushed the huberty89/mv-java-doc-improvement branch from 7b32d11 to f45964a Compare May 10, 2023 14:54
@findepi findepi requested a review from electrum May 10, 2023 15:15
@findepi findepi force-pushed the huberty89/mv-java-doc-improvement branch from f45964a to 52c742f Compare May 10, 2023 18:26
@findepi
Copy link
Member

findepi commented May 10, 2023

thanks @martint for your time. i read your review as an approval.

@github-actions github-actions bot added hive Hive connector tests:hive labels May 10, 2023
@findepi findepi merged commit 09310b7 into trinodb:master May 11, 2023
@huberty89
Copy link
Contributor Author

Thanks

@github-actions github-actions bot added this to the 418 milestone May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed hive Hive connector
Development

Successfully merging this pull request may close these issues.

3 participants