-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update jline to 3.21.0 #10177
Update jline to 3.21.0 #10177
Conversation
@martint out of curiosity, how did you stumble on the exception you've mentioned in the description of the PR? |
I ran the CLI on an M1 Mac. Just tried again and this time it crashed with a SIGSEGV:
|
Just tested and this fix works on Apple M1 systems. |
Any chance this could be looked at again? |
I'm looking into some integration tests that started failing with this PR. |
@martint this is a bug in jline: jline/jline3#751 Could be worked around by removing secondary line prompt in InputReader:
|
Or:
Works for me :) |
@wendigo, updated with your suggestion. Thanks! |
Fixes an incompatibility with ARM64: com.sun.jna.LastErrorException: [14] Bad address at com.sun.jna.Native.invokeVoid(Native Method) at com.sun.jna.Function.invoke(Function.java:415) at com.sun.jna.Function.invoke(Function.java:361) at com.sun.jna.Library$Handler.invoke(Library.java:265) at com.sun.proxy.$Proxy6.ioctl(Unknown Source) at org.jline.terminal.impl.jna.osx.OsXNativePty.getSize(OsXNativePty.java:82)
Fixes an incompatibility with ARM64: