Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IcebergSplitSource: Support large IN predicates #9743

Closed
alexjo2144 opened this issue Oct 22, 2021 · 1 comment · Fixed by #23625
Closed

IcebergSplitSource: Support large IN predicates #9743

alexjo2144 opened this issue Oct 22, 2021 · 1 comment · Fixed by #23625

Comments

@alexjo2144
Copy link
Member

TODO from the code:

Remove TupleDomain#simplify once Iceberg supports IN expression. Currently this is required for IN predicates on non-partition columns with large value list. Such predicates on partition columns are not supported. (See AbstractTestIcebergSmoke#testLargeInFailureOnPartitionedColumns)

@findepi : I think the TODO wording is overly optimistic, especially in context of DF, which can produce larger domains than usually.
#9193 (comment)

@findepi
Copy link
Member

findepi commented Jun 10, 2022

once Iceberg supports IN expression.

Iceberg supports them (#10032 uses them)

TODO from the code: Remove TupleDomain#simplify [...]

it apparently got removed in #9193
( https://github.com/trinodb/trino/pull/9193/files#diff-5f16ce85422fcac65b098c620431d97805cf6ca538d8166a35526004591abf8eL65 )

I think the TODO wording is overly optimistic, especially in context of DF,

@alexjo2144 that's possible.
Maybe we should close this issue?

cc @raunaqmorarka

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

2 participants