Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable hive.s3.streaming by default #9715

Merged
merged 1 commit into from
Nov 9, 2021

Conversation

joshthoward
Copy link
Member

No description provided.

@cla-bot cla-bot bot added the cla-signed label Oct 20, 2021
@joshthoward joshthoward requested a review from electrum October 20, 2021 16:30
@raunaqmorarka
Copy link
Member

Test failures are related to change

Failures: 
39976
Error:    TestHiveS3Config.testDefaults:39 S3StreamingUploadEnabled expected [false] but found [true]
39977
Error:    TestTrinoS3FileSystem.testCreateWithNonexistentStagingDirectory:378 expected [true] but found [false]
39978
Error:    TestTrinoS3FileSystem.testCreateWithStagingDirectoryFile » Test 

@joshthoward
Copy link
Member Author

The following error looks like a flake. I am going to rerun and create an issue if CI passes.

Error:  io.trino.plugin.hive.TestHive2InsertOverwrite.setUp  Time elapsed: 227.903 s  <<< FAILURE!
java.lang.RuntimeException: Schema already exists: 'hive_insert_overwrite'
	at io.trino.testing.AbstractTestingTrinoClient.execute(AbstractTestingTrinoClient.java:121)
	at io.trino.testing.DistributedQueryRunner.execute(DistributedQueryRunner.java:476)
	at io.trino.testing.AbstractTestQueryFramework.computeActual(AbstractTestQueryFramework.java:153)
	at io.trino.testing.AbstractTestQueryFramework.computeActual(AbstractTestQueryFramework.java:148)
	at io.trino.plugin.hive.BaseTestHiveInsertOverwrite.setUp(BaseTestHiveInsertOverwrite.java:74)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/java.lang.reflect.Method.invoke(Method.java:566)
	at org.testng.internal.MethodInvocationHelper.invokeMethod(MethodInvocationHelper.java:104)
	at org.testng.internal.Invoker.invokeConfigurationMethod(Invoker.java:515)
	at org.testng.internal.Invoker.invokeConfigurations(Invoker.java:217)
	at org.testng.internal.Invoker.invokeConfigurations(Invoker.java:144)
	at org.testng.internal.TestMethodWorker.invokeBeforeClassMethods(TestMethodWorker.java:169)
	at org.testng.internal.TestMethodWorker.run(TestMethodWorker.java:108)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
	at java.base/java.lang.Thread.run(Thread.java:829)
	Suppressed: java.lang.Exception: SQL: CREATE SCHEMA hive.hive_insert_overwrite WITH (location='s3a://test-hive-insert-overwrite-ex88bwfppz/hive_insert_overwrite')
		at io.trino.testing.DistributedQueryRunner.execute(DistributedQueryRunner.java:479)
		... 16 more

@joshthoward joshthoward reopened this Oct 26, 2021
@joshthoward
Copy link
Member Author

The previous error was a flake. The current CI error is definitely a flake.

Error:  Tests run: 229, Failures: 1, Errors: 0, Skipped: 54, Time elapsed: 471.792 s <<< FAILURE! - in TestSuite
Error:  io.trino.plugin.phoenix5.TestPhoenixConnectorTest.testRowLevelDelete  Time elapsed: 1.12 s  <<< FAILURE!
java.lang.RuntimeException: 
Failed after attempts=4, exceptions:
2021-10-26T16:57:21.382Z, RpcRetryingCaller{globalStartTime=1635267441379, pause=100, maxAttempts=4}, org.apache.hadoop.hbase.NotServingRegionException: org.apache.hadoop.hbase.NotServingRegionException: hbase:meta,,1.1588230740 is closing
	at org.apache.hadoop.hbase.regionserver.HRegion.startRegionOperation(HRegion.java:8455)
	at org.apache.hadoop.hbase.regionserver.HRegion.getScanner(HRegion.java:2972)
	at org.apache.hadoop.hbase.regionserver.HRegion.getScanner(HRegion.java:2967)
	at org.apache.hadoop.hbase.regionserver.HRegion.getScanner(HRegion.java:2961)
	at org.apache.hadoop.hbase.regionserver.RSRpcServices.get(RSRpcServices.java:2642)
	at org.apache.hadoop.hbase.regionserver.RSRpcServices.get(RSRpcServices.java:2569)
	at org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$ClientService$2.callBlockingMethod(ClientProtos.java:42274)
	at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:418)
	at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:133)
	at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:338)
	at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:318)

@electrum electrum merged commit 7ccedcd into trinodb:master Nov 9, 2021
@electrum
Copy link
Member

electrum commented Nov 9, 2021

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants