Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove usages of deprecated Files.createTempDir #6908

Closed
4 tasks
findepi opened this issue Feb 16, 2021 · 5 comments · Fixed by #10313
Closed
4 tasks

Remove usages of deprecated Files.createTempDir #6908

findepi opened this issue Feb 16, 2021 · 5 comments · Fixed by #10313
Labels
good first issue Good for newcomers maintenance Project maintenance task

Comments

@findepi
Copy link
Member

findepi commented Feb 16, 2021 •
edited by ebyhr
Loading

com.google.common.io.Files#createTempDir is deprecated.
java.nio.file.Files#createTempDirectory should be used instead.
@findepi findepi added good first issue Good for newcomers maintenance Project maintenance task labels Feb 16, 2021
@vaibhavkhanduja
Copy link

vaibhavkhanduja commented Feb 18, 2021 •
edited
Loading

@findepi as a newbie .. can I take a look at this?

@findepi
Copy link
Member Author

findepi commented Feb 19, 2021

@vaibhavkhanduja absolutely, go for it!

since i think there are multiple occurrences of the deprecated function, i recommend to do this in steps.
Fix a couple, do a PR. Then fix another couple. Small PRs are best to work with.

@hguercan
Copy link
Member

hguercan commented May 2, 2021

Started also working on this issue since its open since 19 Feb. Hope this is fine.

@ebyhr
Copy link
Member

ebyhr commented May 7, 2021

@findepi Do we update modernizer configuration in this issue?

@ebyhr ebyhr mentioned this issue May 8, 2021
Merged
@mohitsaxenaknoldus
Copy link

Can I be assigned to it? I can do it.

@joshthoward joshthoward mentioned this issue Dec 15, 2021
Merged
@jtraglia jtraglia mentioned this issue Mar 31, 2022
Closed
2 tasks
@bowenliang123 bowenliang123 mentioned this issue Aug 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers maintenance Project maintenance task
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replace deprecated Guava method createTempDir joshthoward/trino
5 participants
@findepi @vaibhavkhanduja @ebyhr @hguercan @mohitsaxenaknoldus