-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove reserved pool #6677
Comments
I assume after this refactor there should always be a single memory pool and it should be reflected at the code level. More specifically it would result in replacing Is my understanding correct? |
@arhimondr i am not entirely sure about this. i am personally ok either way, but please wait for opinion from others |
Could multiple memory pools potentially be used with resource groups in the future? |
I don't think there's currently any use case for multiple pools, so if we're going to have just one, we should get rid of the infrastructure for managing multiple ones. We can always add that back if it ever becomes necessary. |
I think we should get rid of supporting multiple pools, unless there is some reason someone to keep it right now. We can always add a new system if some comes up with a reason to segment usage in the future. |
Discussion link: https://trinodb.slack.com/archives/CP1MUNEUX/p1610630362006000
The text was updated successfully, but these errors were encountered: