Run Phoenix product test after 5.2.1 upgrade

[virajjasani]

Description

Enable Phoenix product tests.

HBase 2.5.10 has a fix required to stabilize Phoenix tests in the docker environment. Since Phoenix 5.2.1 with HBase 2.5.10-hadoop3 are already used by Trino, the fix is available for trino to consume.

Release notes

(x) This is not user-visible or is docs only, and no release notes are required.

[cla-bot]

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

[cla-bot]

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

[virajjasani]

@wendigo could you please take a look?

[ebyhr]

Could you run stress tests likes #21480? Removing unnecessary jobs and duplicating a Phoenix job.

[cla-bot]

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

[virajjasani]

Could you run stress tests likes #21480?

Could you please help me understand how I can run it? So far, I confirmed the changes with
testing/trino-product-tests-launcher/bin/run-launcher test run --config config-default --environment multinode-phoenix5 -- -g configured_features,phoenix

[ebyhr]

@virajjasani I mean removing unnecessary jobs and duplicating a Phoenix job (10 lines) in ci.yml.

[ebyhr]

Is #21569 a client side issue? Our testing target version is still 5.2.0. https://github.com/trinodb/docker-images/blob/a8bd3d297cbf23ea815856cb43901632f23ed677/testing/phoenix5/Dockerfile#L18

[virajjasani]

Is #21569 a client side issue?

No, it was server side issue, which is fixed with HBase 2.5.9 (Jira: HBASE-28567)

[virajjasani]

Our testing target version is still 5.2.0.

Thanks for pointing this! Can i update it in addition to this PR?

[cla-bot]

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

[virajjasani]

Upgrade Phoenix version in docker image to 5.2.1: trinodb/docker-images#220

[virajjasani]

@ebyhr I guess I might have removed even some necessary job, all the trino-phoenix5 jobs are failing. Probably I can restore everything back and still repeat trino-phoenix5 at least 20 times for stress testing?

[cla-bot]

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

[cla-bot]

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

[virajjasani]

@ebyhr @lhofhansl The build result of stress test looks good, let me revert the changes and make PR ready for review.

[cla-bot]

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

[ebyhr]

@virajjasani You should run product tests pt, not integration tests test because you updated testing/trino-product-tests/src/main/java/io/trino/tests/product/phoenix/TestPhoenix.java

[cla-bot]

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

[virajjasani]

@virajjasani You should run product tests pt, not integration tests test because you updated testing/trino-product-tests/src/main/java/io/trino/tests/product/phoenix/TestPhoenix.java

I am bit confused. It seems Trino does not have SuitePhoenix* or suite-phoenix* in ci.yaml. Also, #21569 build results were also focused on trino-phoenix5 unless I am mistaken. I might be missing something fundamental here.

[ebyhr]

@virajjasani You can check Suite6NonGeneric.