Introduce SystemEnvironmentUtils #24501
Merged
+177
−180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebyhr
reviewed
Dec 17, 2024
krvikash
force-pushed
the
krvikash/product-test-env
branch
from
0bbb59d to
cc37303
Compare
github-actions
bot
added
iceberg
|
Thanks, @ebyhr for the review. AC. |
krvikash
requested review from
ssheikin,
Praveen2112,
vlad-lyutenko and
marcinsbd
krvikash
force-pushed
the
krvikash/product-test-env
branch
from
cc37303 to
f590a5b
Compare
Praveen2112
approved these changes
Dec 17, 2024
testing/trino-testing-services/src/main/java/io/trino/testing/SystemEnvUtils.java
Outdated
Show resolved
Hide resolved
krvikash
force-pushed
the
krvikash/product-test-env
branch
from
f590a5b to
79dd5a3
Compare
marcinsbd
approved these changes
Dec 17, 2024
ssheikin
approved these changes
Dec 17, 2024
krvikash
force-pushed
the
krvikash/product-test-env
branch
2 times, most recently
from
93bda35 to
acf9f11
Compare
|
(rebased with master) |
Praveen2112
reviewed
Dec 18, 2024
testing/trino-testing-services/src/main/java/io/trino/testing/SystemEnvUtils.java
Outdated
Show resolved
Hide resolved
krvikash
force-pushed
the
krvikash/product-test-env
branch
from
acf9f11 to
61d6437
Compare
|
@Praveen2112 AC |
krvikash
force-pushed
the
krvikash/product-test-env
branch
from
61d6437 to
dabd378
Compare
|
(rebased with master) |
in TestSalesforceBasicAuthenticator#createAuthenticatedPrincipalRealBadPassword
krvikash
force-pushed
the
krvikash/product-test-env
branch
from
dabd378 to
342534f
Compare
|
(rebased with master) |
Praveen2112
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release notes
(X) This is not user-visible or is docs only, and no release notes are required.