Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): OPA allow-permission-management-operations config name #24478

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

c-thiel
Copy link

@c-thiel c-thiel commented Dec 15, 2024

Description

Docs do not match implementation for the opa.allow-permission-management-operations configuration property

Additional context and related issues

Release notes

This is not user-visible or is docs only, and no release notes are required.

Copy link

cla-bot bot commented Dec 15, 2024

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

@github-actions github-actions bot added the docs label Dec 15, 2024
@c-thiel
Copy link
Author

c-thiel commented Dec 15, 2024

I just sent the CLA via Mail

Copy link
Member

@ebyhr ebyhr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this. Could you follow our commit message guideline? e.g. "Fix wrong config name in OPA documentation"
https://trino.io/development/process#pull-request-and-commit-guidelines-

Copy link

cla-bot bot commented Dec 16, 2024

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

@c-thiel
Copy link
Author

c-thiel commented Dec 16, 2024

@ebyhr fixed the commit message. Just waiting for the CLA I guess

Copy link

cla-bot bot commented Dec 19, 2024

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants