Page and block builder cleanup #23781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
iceberg
raunaqmorarka
approved these changes
Oct 15, 2024
wendigo
force-pushed
the
page-builder-cleanup
branch
from
8b19eff to
9d91d99
Compare
|
I've fixed error-prone violation in one of the commits |
wendigo
approved these changes
Oct 15, 2024
losipiuk
approved these changes
Oct 15, 2024
dain
force-pushed
the
page-builder-cleanup
branch
from
9d91d99 to
bce9de7
Compare
The types are not needed by users and complicate the implementation
For memory usage calculations getRetainedSizeInBytes should be used
dain
force-pushed
the
page-builder-cleanup
branch
from
bce9de7 to
fe4ce2f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Various cleanups for PageBuilder and BlockBuilders
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.