Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "hive.fs.new-file-inherit-permissions". #23091

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

yukiito2
Copy link

Description

  • Add hive.fs.new-file-inherit-permissions property for hive catalog
  • In case the property is set true, then the new directory's permissions are inherited from the parent directory.

Additional context and related issues

  • This fearture works as follows
    • If the permission of table location (e.g. /path/to/test) is 0740
    • The permission of the partition directory (e.g. /path/to/test/partition) inherits 740.
  • This feature is only available if hive.fs.new-directory-permissions = 'skip'.
    • If not 'skip', the permission in hive.fs.new-directory-permissions is used.

Release notes

( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
(x) Release notes are required, with the following suggested text:

# Section
* Add `hive.fs.new-file-inherit-permissions`. If the property is set true and `hive.fs.new-directory-permissions` = 'skip', then the new directory's permissions are inherited from the parent directory.

Copy link

cla-bot bot commented Aug 21, 2024

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: yukiito.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email [email protected]
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

1 similar comment
Copy link

cla-bot bot commented Aug 21, 2024

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: yukiito.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email [email protected]
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@yukiito2 yukiito2 force-pushed the inherit-directory-permissions branch from b4ef9c8 to 708f1b4 Compare August 23, 2024 03:05
Copy link

cla-bot bot commented Aug 23, 2024

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: yukiito.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email [email protected]
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@raunaqmorarka raunaqmorarka requested a review from electrum August 27, 2024 13:34
Copy link

cla-bot bot commented Aug 28, 2024

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: yukiito.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email [email protected]
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

Copy link

cla-bot bot commented Aug 28, 2024

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: yukiito.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email [email protected]
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

Copy link

This pull request has gone a while without any activity. Tagging the Trino developer relations team: @bitsondatadev @colebow @mosabua

@github-actions github-actions bot added the stale label Sep 18, 2024
Copy link

Closing this pull request, as it has been stale for six weeks. Feel free to re-open at any time.

@github-actions github-actions bot closed this Oct 10, 2024
@electrum electrum reopened this Oct 10, 2024
@mosabua mosabua added stale-ignore Use this label on PRs that should be ignored by the stale bot so they are not flagged or closed. and removed stale labels Oct 10, 2024
@mosabua
Copy link
Member

mosabua commented Oct 10, 2024

👋 @yukiito2 could you please submit a signed CLA?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale-ignore Use this label on PRs that should be ignored by the stale bot so they are not flagged or closed.
Development

Successfully merging this pull request may close these issues.

3 participants