Add support for CombineTextInputFormat from Hive

[sjdurfey]

Description

As brought up in #21842, I am unable to query text based hive tables that use org.apache.hadoop.mapred.lib.CombineTextInputFormat. I get this error:

io.trino.spi.TrinoException: Unsupported storage format: mydatabase.mytable:<UNPARTITIONED> StorageFormat{serde=org.apache.hadoop.hive.serde2.lazy.LazySimpleSerDe, inputFormat=org.apache.hadoop.mapred.lib.CombineTextInputFormat, outputFormat=org.apache.hadoop.hive.ql.io.HiveIgnoreKeyTextOutputFormat}

This change was the suggestion from the linked issue. To test this out I tried to query with Trino 453 without the code change, and I get this error on the CLI:

$ ./trino https://localhost:8443 --catalog hive
trino> select count(*) from <my hive table>;
Query 20240819_203410_00002_cg577 failed: Unsupported storage format: <my hive table>:dateint=20240810/state=open StorageFormat{serde=org.apache.hadoop.hive.serde2.lazy.LazySimpleSerDe, inputFormat=org.apache.hadoop.mapred.lib.CombineTextInputFormat, outputFormat=org.apache.hadoop.hive.ql.io.HiveIgnoreKeyTextOutputFormat}

Then I built the hive plugin jar with the code change and copied it onto the Trino docker image I was using, and re-ran my query with success:

$ ./trino https://localhost:8443 --catalog hive
trino> select count(*) from <my hive table>;
 _col0
--------
 242185
(1 row)

Query 20240819_203152_00000_r8kgb, FINISHED, 1 node
Splits: 5,616 total, 5,616 done (100.00%)
30.30 [242K rows, 131MB] [7.99K rows/s, 4.31MB/s]

Release notes

(x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text:

c.c. @electrum

[cla-bot]

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

[github-actions]

This pull request has gone a while without any activity. Tagging the Trino developer relations team: @bitsondatadev @colebow @mosabua

[mosabua]

@cla-bot check

[cla-bot]

The cla-bot has been summoned, and re-checked this pull request!

[mosabua]

Can you change the commit message to

Add support for CombineTextInputFormat from Hive

[sjdurfey]

@mosabua, the commit message has been changed. I'm not sure how to re-run the failing delta lake build

[sjdurfey]

is there anything else that I need to do on this PR for it to be merged?

[hashhar]

@mosabua PTAL at release notes. This is ready to be merged.

[mosabua]

I will take care of release notes in the 461 RN PR.

[mosabua]

Added to release note now with suggested RN entry

[mosabua]

Thank you for the PR @sjdurfey .. this will be in the upcoming 461 release

[sjdurfey]

woohoo! Thanks, and you're welcome!