Add debug log statements for pinot PQL #22221
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naman-patel
changed the title
naman-patel
force-pushed
the
log-queries
branch
2 times, most recently
from
635c6a7 to
bc031a9
Compare
naman-patel
changed the title
ebyhr
reviewed
May 31, 2024
plugin/trino-pinot/src/main/java/io/trino/plugin/pinot/query/DynamicTablePqlExtractor.java
Outdated
Show resolved
Hide resolved
plugin/trino-pinot/src/main/java/io/trino/plugin/pinot/query/PinotQueryBuilder.java
Outdated
Show resolved
Hide resolved
|
@ebyhr done. Changed all to debug. |
naman-patel
force-pushed
the
log-queries
branch
2 times, most recently
from
e1741c8 to
aabcd63
Compare
ebyhr
reviewed
Jun 3, 2024
plugin/trino-pinot/src/main/java/io/trino/plugin/pinot/PinotPageSourceProvider.java
Show resolved
Hide resolved
plugin/trino-pinot/src/main/java/io/trino/plugin/pinot/query/DynamicTablePqlExtractor.java
Outdated
Show resolved
Hide resolved
plugin/trino-pinot/src/main/java/io/trino/plugin/pinot/query/DynamicTablePqlExtractor.java
Outdated
Show resolved
Hide resolved
plugin/trino-pinot/src/main/java/io/trino/plugin/pinot/query/PinotQueryBuilder.java
Outdated
Show resolved
Hide resolved
|
Please update PR title. |
naman-patel
force-pushed
the
log-queries
branch
2 times, most recently
from
635cdc3 to
e1758f3
Compare
ebyhr
reviewed
Jun 3, 2024
| @@ -75,7 +78,7 @@ public ConnectorPageSource createPageSource( | |||
| } | |||
| PinotTableHandle pinotTableHandle = (PinotTableHandle) tableHandle; | |||
| String query = generatePql(pinotTableHandle, handles, pinotSplit.getSuffix(), pinotSplit.getTimePredicate(), limitForSegmentQueries); | |||
|
|
|||
| LOG.debug("Pinot query: %s", query); | |||
There was a problem hiding this comment.
The logging place looks still wrong. Note that #22253 is going to move the above generatePql method call because it's redundant in case of dynamic tables.
There was a problem hiding this comment.
In that case let me close the PR.
plugin/trino-pinot/src/main/java/io/trino/plugin/pinot/PinotPageSourceProvider.java
Outdated
Show resolved
Hide resolved
Please use a more helpful commit title. e.g. "Add debug log for generated Pinot SQL" |
naman-patel
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
To do a better debuging of Pinot performance issues we are trying to log the queries. There is no way we can do that. I do feel there should be a general approach for enabling this across but for now we desperately need this.
Additional context and related issues
The PR allows a connector setting to log the queries executed against a pinot catalog. This helps better query tracking.
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.