Migrate iceberg caching product test to native filesystem #22217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nineinchnick
approved these changes
May 31, 2024
| hive.s3.endpoint=http://minio:9080/ | ||
| hive.s3.path-style-access=true | ||
| hive.s3.ssl.enabled=false | ||
| fs.native-s3.enabled=true |
There was a problem hiding this comment.
Can we also disable the legacy libs with fs.hadoop.enabled=false?
There was a problem hiding this comment.
ya this will require slightly more changes.. I will update this PR with the required changes. Looks like we can apply the same for many other product-tests which were already migrated.
ebyhr
approved these changes
May 31, 2024
|
is pt (default, suite-iceberg, ) failure related? |
yes it is. I will look into it |
anusudarsan
force-pushed
the
anu/migrate-iceberg-cached-pt-nfs
branch
from
e5d8bbf to
e5ce039
Compare
anusudarsan
force-pushed
the
anu/migrate-iceberg-cached-pt-nfs
branch
from
e5ce039 to
7d6522d
Compare
ebyhr
approved these changes
Jun 18, 2024
...in/java/io/trino/tests/product/launcher/env/environment/EnvMultinodeIcebergMinioCaching.java
Show resolved
Hide resolved
ebyhr
force-pushed
the
anu/migrate-iceberg-cached-pt-nfs
branch
from
7d6522d to
58a929c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Additional context and related issues
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.