Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the default precision of timestamp to micros (6) as specified by SQL standard. #20292

Open
amoghmargoor opened this issue Jan 8, 2024 · 4 comments
Labels
roadmap Top level issues for major efforts in the project

Comments

@amoghmargoor
Copy link
Member

The default precision for timestamp was chosen as 3 and it was decided to make it 6 in future as specified by SQL standard as specified by comment here: #1284 (comment). Code link:

public static final int DEFAULT_PRECISION = 3; // TODO: should be 6 per SQL spec
.

@amoghmargoor amoghmargoor changed the title Change the default precision of timestamp to micros (6) Change the default precision of timestamp to micros (6) as specified by SQL standard. Jan 8, 2024
@amoghmargoor
Copy link
Member Author

PR: #20290

@jkylling
Copy link
Contributor

jkylling commented Feb 1, 2024

The Delta Lake connector is looking to make a similar change: #20359

@Samrose-Ahmed
Copy link

Why was the PR closed, interested in this as well for Iceberg.

@mosabua
Copy link
Member

mosabua commented May 7, 2024

We will need to break this work down. The support for higher precision varies across data sources, and for table formats also depends on the file format, metastore and other factors.

As such we might have to figure out how to enable this on a fine-grained basis. Maybe per catalog with a catalog configuration property. And if we do a global configuration .. what do we do - fail queries?

Essentially this requires more thought and work before we can ship this, but to be clear. We do want to proceed.

@mosabua mosabua added the roadmap Top level issues for major efforts in the project label May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
roadmap Top level issues for major efforts in the project
Development

No branches or pull requests

4 participants