Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document on system information rules is incorrect #19781

Closed
oneonestar opened this issue Nov 17, 2023 · 2 comments · Fixed by #20462
Closed

Document on system information rules is incorrect #19781

oneonestar opened this issue Nov 17, 2023 · 2 comments · Fixed by #20462
Labels

Comments

@oneonestar
Copy link
Member

oneonestar commented Nov 17, 2023

These rules specify which users can access the system information management interface. System information access includes the following aspects:
Read access to details such as Trino version, uptime of the node, and others from the /v1/info and /v1/status REST endpoints.

Document states that read access from /v1/info and /v1/status are affected by system information rules. However they are not.

Public:

  • HEAD /v1/status
  • GET /v1/status
  • GET /v1/info
  • GET /v1/info/state
  • GET /v1/info/coordinator

MANAGEMENT_WRITE check:

  • PUT /v1/info/state (Endpoint for graceful shutdown)

Ref:


#17153

@mosabua
Copy link
Member

mosabua commented Jan 24, 2024

@dain @electrum is the implementation as desired so we should update the docs?

@oneonestar can you send a PR potentially?

@hashhar
Copy link
Member

hashhar commented Jan 25, 2024

/v1/status at the very least is expected to be public since they are used as health-checks by things like load-balancers, our Docker images, k8s probes and so on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging a pull request may close this issue.

3 participants