Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BaseDeltaLakeConnectorSmokeTest.testHistoryTableWithDeletedTransactionLog is failing against ADLS and GCS #19044

Closed
krvikash opened this issue Sep 14, 2023 · 0 comments · Fixed by #19048

Comments

@krvikash
Copy link
Contributor

Test case added in #18845 is failing against ADLS and GCS. However, The test is passing against AWS.

Error:  io.trino.plugin.deltalake.TestDeltaLakeGcsConnectorSmokeTest.testHistoryTableWithDeletedTransactionLog -- Time elapsed: 1.223 s <<< FAILURE!
java.lang.AssertionError: 
For query 20230914_081642_00381_mhhxg: 
 SELECT version, operation FROM "test_history_table_with_deleted_transaction_log9x6wnugvfd$history"
not equal
Actual rows (up to 100 of 2 extra rows shown, 5 rows in total):
    [0, CREATE TABLE]
    [1, WRITE]
Expected rows (up to 100 of 0 missing rows shown, 3 rows in total):
    

	at org.testng.Assert.fail(Assert.java:94)
	at io.trino.testing.QueryAssertions.assertEqualsIgnoreOrder(QueryAssertions.java:382)
	at io.trino.testing.QueryAssertions.assertDistributedQuery(QueryAssertions.java:348)
	at io.trino.testing.QueryAssertions.assertQuery(QueryAssertions.java:184)
	at io.trino.testing.QueryAssertions.assertQuery(QueryAssertions.java:157)
	at io.trino.testing.AbstractTestQueryFramework.assertQuery(AbstractTestQueryFramework.java:346)
	at io.trino.plugin.deltalake.BaseDeltaLakeConnectorSmokeTest.testHistoryTableWithDeletedTransactionLog(BaseDeltaLakeConnectorSmokeTest.java:1981)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/java.lang.reflect.Method.invoke(Method.java:568)
	at org.testng.internal.MethodInvocationHelper.invokeMethod(MethodInvocationHelper.java:104)
	at org.testng.internal.Invoker.invokeMethod(Invoker.java:645)
	at org.testng.internal.Invoker.invokeTestMethod(Invoker.java:851)
	at org.testng.internal.Invoker.invokeTestMethods(Invoker.java:1177)
	at org.testng.internal.TestMethodWorker.invokeTestMethods(TestMethodWorker.java:129)
	at org.testng.internal.TestMethodWorker.run(TestMethodWorker.java:112)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635)
	at java.base/java.lang.Thread.run(Thread.java:833)

For ADLS/GCS, I've noticed no files in the MINIO bucket. As a result, the attempt to delete a file using the statements below has no-op. This cause is leading to the assertion failure.

minio.removeObject(bucketName, "%s/_delta_log/%020d.json".formatted(key, 0));
minio.removeObject(bucketName, "%s/_delta_log/%020d.json".formatted(key, 1));
@krvikash krvikash changed the title TestDeltaLakeGcsConnectorSmokeTest.testHistoryTableWithDeletedTransactionLog is failing against ADLS and GCS BaseDeltaLakeConnectorSmokeTest.testHistoryTableWithDeletedTransactionLog is failing against ADLS and GCS Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

1 participant