You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We have test for LIKE pushdown TestPostgreSqlConnectorTest.testLikePredicatePushdown()
Looks like it passing only because we have case sensitive columns in our test by default.
If we change collation for columns - it will fails.
I think we need to enable this pushdown only if column is case sensitive or we use enable_string_pushdown_with_collate.
The same problem with SQLServer.
So for example if table is case insensitive and we execute select, we could get different result with and without push down.
data : ABC, Abc, AbC, abc.
SELECT * WHERE column LIKE %abc% - with pushdown - ABC, Abc, AbC, abc.
without pushdown - abc
Here is attempt to apply this logic for MySql #18441
The text was updated successfully, but these errors were encountered:
vlad-lyutenko
changed the title
Enable LIKE predicate pushdown only for case sensitive columns ( or with direct C collate)
Enable LIKE predicate pushdown only for case sensitive columns or with direct C collate (Postgres, SQLServer)
Jul 25, 2023
vlad-lyutenko
changed the title
Enable LIKE predicate pushdown only for case sensitive columns or with direct C collate (Postgres, SQLServer)
Silent correctness issue for PSQL and SQLServer for LIKE predicate pushdown
Jul 31, 2023
We have test for LIKE pushdown TestPostgreSqlConnectorTest.testLikePredicatePushdown()
Looks like it passing only because we have case sensitive columns in our test by default.
If we change collation for columns - it will fails.
I think we need to enable this pushdown only if column is case sensitive or we use enable_string_pushdown_with_collate.
The same problem with SQLServer.
So for example if table is case insensitive and we execute select, we could get different result with and without push down.
Here is attempt to apply this logic for MySql #18441
The text was updated successfully, but these errors were encountered: