Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Column properties are ignored when the column name contains uppercase characters #18013

Closed
findinpath opened this issue Jun 22, 2023 · 0 comments · Fixed by #18123
Closed

Column properties are ignored when the column name contains uppercase characters #18013

findinpath opened this issue Jun 22, 2023 · 0 comments · Fixed by #18123
Assignees
Labels
bug Something isn't working delta-lake Delta Lake connector

Comments

@findinpath
Copy link
Contributor

On Databricks/Spark

CREATE TABLE findinpathtable(
eventId BIGINT COMMENT 'event identifier comment',
data STRING
)
USING DELTA
LOCATION 's3://like/my/comment' ;

On Trino

describe findinpathtable;

Due to the fact that the column eventId is saved under this name in the metadata string, its comment doesn't get shown in the DESCRIBE statement.

Same issue for the statement:

select *, comment from mycatalog.information_schema.columns
where table_catalog = 'mycatalog' and table_schema = 'myschema' and table_name = 'findinpathtable';

Other operations may be affected as well.
Check for the usages of the method io.trino.plugin.deltalake.transactionlog.DeltaLakeSchemaSupport#getColumnProperties

@findinpath findinpath added bug Something isn't working delta-lake Delta Lake connector labels Jun 22, 2023
@ebyhr ebyhr self-assigned this Jun 22, 2023
@ebyhr ebyhr changed the title Delta Lake: Comment not shown in case that the column name contains upper case letters Column properties are ignored when the column name contains uppercase characters Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working delta-lake Delta Lake connector
Development

Successfully merging a pull request may close this issue.

2 participants