Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flaky test TestHashSemiJoinOperator.testSemiJoinMemoryReservationYield #16987

Closed
findepi opened this issue Apr 12, 2023 · 4 comments · Fixed by #17491
Closed

Flaky test TestHashSemiJoinOperator.testSemiJoinMemoryReservationYield #16987

findepi opened this issue Apr 12, 2023 · 4 comments · Fixed by #17491
Labels
bug Something isn't working

Comments

@findepi
Copy link
Member

findepi commented Apr 12, 2023

https://github.com/trinodb/trino/actions/runs/4675961675/jobs/8282707687 (#16970)

2023-04-12T03:45:20.036-0600	ERROR	pool-24-thread-2	io.trino.testng.services.ProgressLoggingListener	[TEST FAILURE] io.trino.operator.TestHashSemiJoinOperator.testSemiJoinMemoryReservationYield [bigint]; (took: 0.1 seconds)
java.lang.IllegalArgumentException: Invalid taskId another_query.0.0
	at io.trino.spi.QueryId.checkArgument(QueryId.java:114)
	at io.trino.spi.QueryId.parseDottedId(QueryId.java:103)
	at io.trino.execution.TaskId.getQueryId(TaskId.java:57)
	at io.trino.memory.MemoryPool.reserve(MemoryPool.java:133)
	at io.trino.operator.GroupByHashYieldAssertion.finishOperatorWithYieldingGroupByHash(GroupByHashYieldAssertion.java:108)
	at io.trino.operator.TestHashSemiJoinOperator.testSemiJoinMemoryReservationYield(TestHashSemiJoinOperator.java:241)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:104)
	at java.base/java.lang.reflect.Method.invoke(Method.java:578)
	at org.testng.internal.MethodInvocationHelper.invokeMethod(MethodInvocationHelper.java:104)
	at org.testng.internal.Invoker.invokeMethod(Invoker.java:645)
	at org.testng.internal.Invoker.invokeTestMethod(Invoker.java:851)
	at org.testng.internal.Invoker.invokeTestMethods(Invoker.java:1177)
	at org.testng.internal.TestMethodWorker.invokeTestMethods(TestMethodWorker.java:129)
	at org.testng.internal.TestMethodWorker.run(TestMethodWorker.java:112)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1144)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:642)
	at java.base/java.lang.Thread.run(Thread.java:1623)
@findepi findepi added the bug Something isn't working label Apr 12, 2023
@findepi
Copy link
Member Author

findepi commented Apr 12, 2023

cc @lukasz-stec @skrzypo987 @sopel39 per #12336

@findepi
Copy link
Member Author

findepi commented Apr 18, 2023 

java.lang.IllegalArgumentException: Invalid taskId another_query.0.0
	at io.trino.spi.QueryId.checkArgument(QueryId.java:114)
	at io.trino.spi.QueryId.parseDottedId(QueryId.java:103)
	at io.trino.execution.TaskId.getQueryId(TaskId.java:57)
	at io.trino.memory.MemoryPool.reserve(MemoryPool.java:133)
	at io.trino.operator.GroupByHashYieldAssertion.finishOperatorWithYieldingGroupByHash(GroupByHashYieldAssertion.java:108)
	at io.trino.operator.TestHashSemiJoinOperator.testSemiJoinMemoryReservationYield(TestHashSemiJoinOperator.java:241)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:104)
	at java.base/java.lang.reflect.Method.invoke(Method.java:578)
	at org.testng.internal.MethodInvocationHelper.invokeMethod(MethodInvocationHelper.java:104)
	at org.testng.internal.Invoker.invokeMethod(Invoker.java:645)
	at org.testng.internal.Invoker.invokeTestMethod(Invoker.java:851)
	at org.testng.internal.Invoker.invokeTestMethods(Invoker.java:1177)
	at org.testng.internal.TestMethodWorker.invokeTestMethods(TestMethodWorker.java:129)
	at org.testng.internal.TestMethodWorker.run(TestMethodWorker.java:112)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1144)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:642)
	at java.base/java.lang.Thread.run(Thread.java:1623)

@lukasz-stec
Copy link
Member

I would add validation to the TaskId string constructor that it conforms to the required format cc @Dith3r

@Dith3r
Copy link
Member

Dith3r commented May 2, 2023

QueryId is validating arguments, StageId adds only integer to queryId, same as TaskId.

@findepi findepi mentioned this issue May 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Put testing with with JDK 20 on hold findepi/trino
3 participants
@findepi @Dith3r @lukasz-stec