Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Trino CTAS data setup process for Ignite connector #16214

Closed
chenjian2664 opened this issue Feb 22, 2023 · 3 comments · Fixed by #16423
Closed

Support Trino CTAS data setup process for Ignite connector #16214

chenjian2664 opened this issue Feb 22, 2023 · 3 comments · Fixed by #16423
Labels
good first issue Good for newcomers test

Comments

@chenjian2664
Copy link
Contributor

Added trinoCreateAsSelect DataSetup for Ignite sql type mapping test.
Follow up for #8323
@chenjian2664 chenjian2664 mentioned this issue Feb 22, 2023
Merged
@ebyhr ebyhr added the good first issue Good for newcomers label Feb 22, 2023
@sudip-unb
Copy link
Contributor

I am new to Trino and I am interested to work on this. Thanks in advance.

@chenjian2664
Copy link
Contributor Author

@sudip-unb You can look at the implementation about the io.trino.plugin.ignite.TestIgniteTypeMapping, we only support create the DataSetup by create and then insert, we need to build the DataSetup using create as select(in Trino).
For the demo you can refer the io.trino.plugin.postgresql.TestPostgreSqlTypeMapping

@chenjian2664
Copy link
Contributor Author

chenjian2664 commented Mar 7, 2023 •
edited
Loading

@sudip-unb We want a method similar to TestPostgreSqlTypeMapping.trinoCreateAsSelect in io.trino.plugin.ignite.TestIgniteTypeMapping
And added to all the existing tests

@sudip-unb sudip-unb mentioned this issue Mar 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers test
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Test CREATE TABLE AS SELECT in Ignite type mapping sudip-unb/trino
3 participants
@ebyhr @chenjian2664 @sudip-unb