Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change FetchSize from 1k to 10k #16153

Closed
vikingUnet opened this issue Feb 17, 2023 · 1 comment · Fixed by #16644
Closed

Change FetchSize from 1k to 10k #16153

vikingUnet opened this issue Feb 17, 2023 · 1 comment · Fixed by #16644
Assignees
Labels
enhancement New feature or request user experience

Comments

@vikingUnet
Copy link

Hello!

We have stumped for a month with very slow working Postgresql connector to db from another city -
we have ping 10ms to this host and this producing slow receiving a lot of rows from it.

We changed FetchSize() call value from 1000 to 10 000 and all become fine: data receiving very fast without any network overhead.

Can you explain - is it safe to change FetchSize from 1000 to another value (maybe 1 million rows for iteration), do we have risks with bigger values?

When will release new Trino version, we must rebuild it with this little change - may i ask you to change this value to 10 000 in master branch or create config parameter to be able to change this value globally or even much better for each connector separately to can change this value dynamically without risk if it really necessary? It will be awesome!

Or it will be better to do this source changes in my own Pool Request?

Big Thanks to Trino Team for your work!

@electrum

@chenjian2664
Copy link
Contributor

@vikingUnet I think it's worth to allow customer to define the jdbcFetchSize as it solve your real problem.
I'll start investigate this and many thanks for sharing all of this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request user experience
3 participants