Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve performance of PagesHashStrategy when multiple Block types (flat, rle, dictionary) are used. #15216

Open
Tracked by #15215
lukasz-stec opened this issue Nov 28, 2022 · 0 comments
Open
Tracked by #15215

Improve performance of PagesHashStrategy when multiple Block types (flat, rle, dictionary) are used. #15216

lukasz-stec opened this issue Nov 28, 2022 · 0 comments
Labels
performance

Comments

@lukasz-stec
Copy link
Member

Sub-task of #15215

Currently, PagesHashStrategy will degrade in performance if all 3 block types (flat, dictionary, rle) are used due to a virtual call overhead for example in positionEqualsPositionIgnoreNulls.

One possible way to avoid this issue is to use a row-wise approach to hash tables that copies the incoming rows into the hash table as proposed by project hummingbird (#14237 )
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
performance
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lukasz-stec