Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TestDistributedFaultTolerantEngineOnlyQueries takes longer time to execute #13507

Closed
Praveen2112 opened this issue Aug 5, 2022 · 13 comments
Closed

Comments

@Praveen2112
Copy link
Member

It ends up in crossing the time limit for trino-test module (60 min) in GHA.

2022-08-04T09:40:03.8940316Z 	io.trino.tests.TestDistributedFaultTolerantEngineOnlyQueries running for 27.43m
2022-08-04T09:40:03.8940904Z 	io.trino.tests.TestDistributedFaultTolerantEngineOnlyQueries.testScalarSubquery running for 25.44m.
@Praveen2112
Copy link
Member Author

@ebyhr
Copy link
Member

ebyhr commented Aug 5, 2022

TestHiveFaultTolerantExecutionJoinQueries also took longer time and caused timed out.

2022-08-05T08:45:04.3200406Z 	io.trino.faulttolerant.hive.TestHiveFaultTolerantExecutionJoinQueries.testOutputDuplicatesInsensitiveJoin running for 17.34m
2022-08-05T08:45:04.3201201Z 	io.trino.faulttolerant.hive.TestHiveFaultTolerantExecutionJoinQueries running for 18.98m.

https://github.com/trinodb/trino/runs/7687591861

@ebyhr
Copy link
Member

ebyhr commented Aug 5, 2022

TestHiveFaultTolerantExecutionJoinQueries.testOutputDuplicatesInsensitiveJoin
https://github.com/trinodb/trino/runs/7689410625

@Praveen2112
Copy link
Member Author

TestDistributedFaultTolerantEngineOnlyQueries.testScalarSubquery
https://github.com/trinodb/trino/runs/7725553971

@raunaqmorarka
Copy link
Member

cc: @arhimondr

@arhimondr
Copy link
Contributor

Looking

@raunaqmorarka
Copy link
Member

https://github.com/trinodb/trino/runs/7763457547?check_suite_focus=true

2022-08-10T06:07:37.073-0500	WARN	TestHangMonitor	io.trino.testng.services.LogTestDurationListener	No test started or completed in 8.00m. Running tests:
	io.trino.faulttolerant.hive.TestHiveFaultTolerantExecutionJoinQueries.testOutputDuplicatesInsensitiveJoin running for 18.19m
	io.trino.faulttolerant.hive.TestHiveFaultTolerantExecutionJoinQueries running for 20.00m.

@findepi
Copy link
Member

findepi commented Aug 11, 2022

It seems TestDistributedFaultTolerantEngineOnlyQueries.testScalarSubquery can take over 45 minutes

2022-08-11T10:28:35.1938505Z 2022-08-11T05:28:35.179-0500	WARN	TestHangMonitor	io.trino.testng.services.LogTestDurationListener	No test started or completed in 8.00m. Running tests:
2022-08-11T10:28:35.1939236Z 	io.trino.tests.TestDistributedFaultTolerantEngineOnlyQueries running for 49.29m
2022-08-11T10:28:35.1940018Z 	io.trino.tests.TestDistributedFaultTolerantEngineOnlyQueries.testScalarSubquery running for 45.59m.

https://github.com/trinodb/trino/runs/7783779560?check_suite_focus=true

@findepi
Copy link
Member

findepi commented Aug 11, 2022

Locally the test finishes in one minute on my laptop, so 45 minutes on the CI looks suspicious.

@sopel39
Copy link
Member

sopel39 commented Aug 16, 2022

I've seen another occurrence.

@arhimondr
Copy link
Contributor

I've run both faulty tests for thousands of times over night and haven't been able to reproduce. Still working on it.

@arhimondr
Copy link
Contributor

Fix: #13695

@raunaqmorarka
Copy link
Member

Fixed by #13695

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

6 participants