We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
In VariableWidthBlockEncoding, when reading a block, we don't allocate a new Slice but instead return a view https://github.com/trinodb/trino/blob/master/core/trino-spi/src/main/java/io/trino/spi/block/VariableWidthBlockEncoding.java#L70-L71
VariableWidthBlockEncoding
This is inconsistent with other encodings and makes such blocks return augmented retained sizes. Ideally, we should create a new Slice, but get rid of the extra copy here https://github.com/trinodb/trino/blob/master/core/trino-main/src/main/java/io/trino/execution/buffer/PagesSerde.java#L224-L228. Also in ExchangeSourceReader we will be able to return a view too.
The text was updated successfully, but these errors were encountered:
cc @sopel39
Sorry, something went wrong.
That's my old PR (closed) where I wanted to fix the issue: prestodb/presto#10634. IIRC I've never benchmarked it
#11235 resolves this
linzebing
No branches or pull requests
In
VariableWidthBlockEncoding
, when reading a block, we don't allocate a new Slice but instead return a view https://github.com/trinodb/trino/blob/master/core/trino-spi/src/main/java/io/trino/spi/block/VariableWidthBlockEncoding.java#L70-L71This is inconsistent with other encodings and makes such blocks return augmented retained sizes. Ideally, we should create a new Slice, but get rid of the extra copy here https://github.com/trinodb/trino/blob/master/core/trino-main/src/main/java/io/trino/execution/buffer/PagesSerde.java#L224-L228. Also in ExchangeSourceReader we will be able to return a view too.
The text was updated successfully, but these errors were encountered: