Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extended ClickHouse Date range #11116

Open
tangjiangling opened this issue Feb 21, 2022 · 4 comments
Open

Extended ClickHouse Date range #11116

tangjiangling opened this issue Feb 21, 2022 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@tangjiangling
Copy link
Member

tangjiangling commented Feb 21, 2022

I've confirmed that from version 21.4, Date types are supported in the range 1970-01-01-2149-06-06.

image

We can refer to

But the range of Date in Trino is 1970-01-01-2106-02-07.

https://github.com/trinodb/trino/blob/master/plugin/trino-clickhouse/src/main/java/io/trino/plugin/clickhouse/ClickHouseClient.java#L158-L159

So I think the range of Date types should also be extended in Trino, and the change we may need to make is to pick the corresponding Date range according to the different ClickHouse Server versions.

@ebyhr ebyhr added the enhancement New feature or request label Feb 21, 2022
@tangjiangling
Copy link
Member Author

Planning to send a PR :)

@hashhar
Copy link
Member

hashhar commented Sep 11, 2022

@tangjiangling Should I re-open this since only part of this is done. The other part probably requires reworking Trino DATE type to support even larger values?

Or would you want to create a separate issue?

@tangjiangling
Copy link
Member Author

@hashhar Thanks for the reminder, I will file a new issue.

@tangjiangling tangjiangling reopened this Sep 11, 2022
@tangjiangling
Copy link
Member Author

Thanks for the reminder, I will file a new issue.

Reopening is enough.

see #11148 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

No branches or pull requests

3 participants