Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wait with timeout instead failing immediately if no candidate nodes available in NodeAllocator #11020

Closed
Tracked by #9101
losipiuk opened this issue Feb 11, 2022 · 1 comment · Fixed by #12157
Closed
Tracked by #9101

Wait with timeout instead failing immediately if no candidate nodes available in NodeAllocator #11020

losipiuk opened this issue Feb 11, 2022 · 1 comment · Fixed by #12157
Assignees
@losipiuk

Comments

@losipiuk
Copy link
Member

losipiuk commented Feb 11, 2022 •
edited
Loading

Currently, FixedSizeNodeAllocator and FullNodeCapableNodeAllocator fail immediatelly if there are no candidates (even currently occupied) for given set of node requirements.
More elegant logic would be to wait for some time as new nodes which match requirements can join the cluster.

To be addressed after #10432
This was referenced Feb 11, 2022
Closed
Merged
@losipiuk losipiuk self-assigned this Apr 27, 2022
@losipiuk losipiuk mentioned this issue Apr 27, 2022
Merged
@losipiuk
Copy link
Member Author

Fixed for bin-packing node alloctor via #12157. WIll ignore the other too as they are considered test-only (we should probably get rid of full-node-capable-node-allocator)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@losipiuk losipiuk

Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Do not fail query immediately if no matching nodes available losipiuk/trino
1 participant
@losipiuk