Adding total or system peak memory usage at StatementStats

[miniway]

From https://github.com/trinodb/trino/blob/master/core/trino-main/src/main/java/io/trino/server/protocol/Query.java#L745

Trino is returning only peakUserMemoryReservation to client and hiding peakNonRevocableMemoryReservation or peakTotalMemoryReservation intentionally.

But by the StatementStats there's no way to get total or system peak memory usage and might not get full sense of memory usages as memory limitations are applied to both user and system memories.

So would it be reasonable to add peakNonRevocableMemoryReservation or peakTotalMemoryReservation on the StatementStats? If so, I'll send a PR for this.

[Praveen2112]

We have recently removed the distinction between system and user memory - (#10574) so we don't track - peakNonRevocableMemoryReservation but I guess we could track peakTotalMemoryReservation

cc: @findepi

[miniway]

It sounds great!

[findepi]

@miniway is there anything else TBD here?

[miniway]

the combined memory usage looks good. I’m closing it