From ab9962ca9ac6b98abae6bf30f64d561c43568415 Mon Sep 17 00:00:00 2001 From: Mateusz Gajewski Date: Mon, 10 Jan 2022 12:09:08 +0100 Subject: [PATCH] Remove peak memory usage statistic This statistics is not really useful and most of the time Docker engine returns null for it --- .../trino/tests/product/launcher/env/StatisticsFetcher.java | 4 ---- 1 file changed, 4 deletions(-) diff --git a/testing/trino-product-tests-launcher/src/main/java/io/trino/tests/product/launcher/env/StatisticsFetcher.java b/testing/trino-product-tests-launcher/src/main/java/io/trino/tests/product/launcher/env/StatisticsFetcher.java index 58da99707800..29f320dd94e9 100644 --- a/testing/trino-product-tests-launcher/src/main/java/io/trino/tests/product/launcher/env/StatisticsFetcher.java +++ b/testing/trino-product-tests-launcher/src/main/java/io/trino/tests/product/launcher/env/StatisticsFetcher.java @@ -113,7 +113,6 @@ private Stats toStats(Statistics statistics, Stats previousStats) MemoryStatsConfig memoryStats = statistics.getMemoryStats(); stats.memoryLimit = DataSize.ofBytes(firstNonNull(memoryStats.getLimit(), 0L)).to(GIGABYTE); stats.memoryUsage = DataSize.ofBytes(firstNonNull(memoryStats.getUsage(), 0L)).to(GIGABYTE); - stats.memoryMaxUsage = DataSize.ofBytes(firstNonNull(memoryStats.getMaxUsage(), 0L)).to(GIGABYTE); stats.memoryUsagePerc = 100.0 * firstNonNull(memoryStats.getUsage(), 0L) / firstNonNull(memoryStats.getLimit(), 1L); stats.pids = firstNonNull(statistics.getPidsStats().getCurrent(), -1L); @@ -190,7 +189,6 @@ public static class Stats "mem", "max mem", "mem %", - "peak mem", "pids", "net in", "net out" @@ -202,7 +200,6 @@ public static class Stats private double memoryUsagePerc; private DataSize memoryUsage; private DataSize memoryLimit; - private DataSize memoryMaxUsage; private long pids; public DataSize networkReceived; public DataSize networkSent; @@ -224,7 +221,6 @@ public String[] toRow(String name) memoryLimit.toString(), memoryUsage.toString(), format("%.2f%%", memoryUsagePerc), - memoryMaxUsage.toString(), format("%d", pids), format("%s", networkReceived), format("%s", networkSent)