From 82ed10ae7bb77811a787529d193126f5b2016b0c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=C5=81ukasz=20Osipiuk?= Date: Thu, 3 Oct 2024 18:34:43 +0200 Subject: [PATCH] Remove unnecessary null-check --- .../java/io/trino/memory/RemoteNodeMemory.java | 15 ++++++--------- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/core/trino-main/src/main/java/io/trino/memory/RemoteNodeMemory.java b/core/trino-main/src/main/java/io/trino/memory/RemoteNodeMemory.java index 34d743b232b9..fa3885ce5334 100644 --- a/core/trino-main/src/main/java/io/trino/memory/RemoteNodeMemory.java +++ b/core/trino-main/src/main/java/io/trino/memory/RemoteNodeMemory.java @@ -24,7 +24,6 @@ import io.airlift.log.Logger; import io.airlift.units.Duration; import io.trino.metadata.InternalNode; -import jakarta.annotation.Nullable; import java.net.URI; import java.util.Optional; @@ -95,17 +94,15 @@ public void asyncRefresh() Futures.addCallback(responseFuture, new FutureCallback<>() { @Override - public void onSuccess(@Nullable JsonResponse result) + public void onSuccess(JsonResponse result) { lastUpdateNanos.set(System.nanoTime()); future.compareAndSet(responseFuture, null); - if (result != null) { - if (result.hasValue()) { - memoryInfo.set(Optional.ofNullable(result.getValue())); - } - if (result.getStatusCode() != OK.code()) { - log.warn("Error fetching memory info from %s returned status %d", memoryInfoUri, result.getStatusCode()); - } + if (result.hasValue()) { + memoryInfo.set(Optional.ofNullable(result.getValue())); + } + if (result.getStatusCode() != OK.code()) { + log.warn("Error fetching memory info from %s returned status %d", memoryInfoUri, result.getStatusCode()); } }