Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Framework: Add TPL HYPRE to tested configurations #11532

Closed
tjfulle opened this issue Feb 1, 2023 · 5 comments
Closed

Framework: Add TPL HYPRE to tested configurations #11532

tjfulle opened this issue Feb 1, 2023 · 5 comments
Labels
CLOSED_DUE_TO_INACTIVITY Issue or PR has been closed by the GitHub Actions bot due to inactivity. MARKED_FOR_CLOSURE Issue or PR is marked for auto-closure by the GitHub Actions bot. PA: Framework Issues that fall under the Trilinos Framework Product Area type: enhancement Issue is an enhancement, not a bug

Comments

@tjfulle
Copy link
Contributor

tjfulle commented Feb 1, 2023

In response to #11531: an internal Sandia customer requests that TPL HYPRE (version 2.18.2, https://github.com/hypre-space/hypre/archive/v2.18.2.tar.gz) be added to the PR test configurations.

We suggest the following configuration when building:

export F77=mpif77
export CC=mpicc
export CXX=mpicxx
cmake \
  -DHYPRE_WITH_MPI=ON \
  -DHYPRE_ENABLE_HYPRE_LAPACK=OFF \
  -DTPL_LAPACK_LIBRARIES=<lapack libs> \
  -DHYPRE_ENABLE_HYPRE_BLAS=OFF \
  -DTPL_BLAS_LIBRARIES=<blas libs> \
  -DHYPRE_WITH_OPENMP=OFF \
  -DHYPRE_ENABLE_BIGINT=int64 \
  -DHYPRE_ENABLE_MIXEDINT=OFF \
  -DHYPRE_ENABLE_COMPLEX=OFF \
  -DHYPRE_SHARED=OFF \
  -DHYPRE_ENABLE_FEI=OFF \
  -DHYPRE_WITH_DSUPERLU=OFF \
  $HYPER_SOURCE_DIR

@bartlettroscoe

@tjfulle tjfulle added type: enhancement Issue is an enhancement, not a bug PA: Framework Issues that fall under the Trilinos Framework Product Area labels Feb 1, 2023
@bartlettroscoe
Copy link
Member

@trilinos/framework, @sebrowne

@sebrowne
Copy link
Contributor

sebrowne commented Feb 2, 2023

I will discuss this with @ccober6. Currently we rely on the SEMS TPLs for our underlying TPLs, so if we follow the current methodology, this would have to be preceded by a request for SEMS to install HYPRE.

That being said, I would like to explore a containerized+spack build of Trilinos that does not require SEMS TPLs, so it may be applicable to that test case if we get to working on such a build soon.

@sebrowne
Copy link
Contributor

After discussing this with @ccober6, we will not be adding this configuration to our set of tested configs at this time, given the aforementioned model by which we support TPLs. We can revisit this once we have greater support for the AUE stack from ASC DevOps (I believe that HYPRE is in that stack), or if/once we transition to containerized workflows and can more nimbly support different configurations.

We can leave this issue open.

Copy link

This issue has had no activity for 365 days and is marked for closure. It will be closed after an additional 30 days of inactivity.
If you would like to keep this issue open please add a comment and/or remove the MARKED_FOR_CLOSURE label.
If this issue should be kept open even with no activity beyond the time limits you can add the label DO_NOT_AUTOCLOSE.
If it is ok for this issue to be closed, feel free to go ahead and close it. Please do not add any comments or change any labels or otherwise touch this issue unless your intention is to reset the inactivity counter for an additional year.

@github-actions github-actions bot added the MARKED_FOR_CLOSURE Issue or PR is marked for auto-closure by the GitHub Actions bot. label Feb 14, 2024
Copy link

This issue was closed due to inactivity for 395 days.

@github-actions github-actions bot added the CLOSED_DUE_TO_INACTIVITY Issue or PR has been closed by the GitHub Actions bot due to inactivity. label Mar 16, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Mar 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLOSED_DUE_TO_INACTIVITY Issue or PR has been closed by the GitHub Actions bot due to inactivity. MARKED_FOR_CLOSURE Issue or PR is marked for auto-closure by the GitHub Actions bot. PA: Framework Issues that fall under the Trilinos Framework Product Area type: enhancement Issue is an enhancement, not a bug
Projects
None yet
Development

No branches or pull requests

3 participants