Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kokkos: TaskDAG is not enabled when OpenMP and CUDA without RDC ON. #10366

Closed
kyungjoo-kim opened this issue Mar 24, 2022 · 2 comments
Closed
Labels
CLOSED_DUE_TO_INACTIVITY Issue or PR has been closed by the GitHub Actions bot due to inactivity. MARKED_FOR_CLOSURE Issue or PR is marked for auto-closure by the GitHub Actions bot. pkg: Kokkos type: bug The primary issue is a bug in Trilinos code or tests

Comments

@kyungjoo-kim
Copy link
Contributor

Bug Report

@trilinos/kokkos

Description

#if defined(KOKKOS_ENABLE_CUDA)                                                                                                      
#if defined(KOKKOS_ENABLE_CUDA_RELOCATABLE_DEVICE_CODE)                                                                              
#define KOKKOS_ENABLE_TASKDAG                                                                                                        
#endif                                                                                                                               
// FIXME_SYCL Tasks not implemented                                                                                                  
#elif !defined(KOKKOS_ENABLE_HIP) && !defined(KOKKOS_ENABLE_SYCL)                                                                    
#define KOKKOS_ENABLE_TASKDAG                                                                                                        
#endif 

The above logic does not allow TaskDAG for OpenMP when the OpenMP is enabled with CUDA without RDC. Regardless of CUDA status, the OpenMP tasking should be enabled.

@kyungjoo-kim kyungjoo-kim added the type: bug The primary issue is a bug in Trilinos code or tests label Mar 24, 2022
@github-actions
Copy link

github-actions bot commented Apr 1, 2023

This issue has had no activity for 365 days and is marked for closure. It will be closed after an additional 30 days of inactivity.
If you would like to keep this issue open please add a comment and/or remove the MARKED_FOR_CLOSURE label.
If this issue should be kept open even with no activity beyond the time limits you can add the label DO_NOT_AUTOCLOSE.
If it is ok for this issue to be closed, feel free to go ahead and close it. Please do not add any comments or change any labels or otherwise touch this issue unless your intention is to reset the inactivity counter for an additional year.

@github-actions github-actions bot added the MARKED_FOR_CLOSURE Issue or PR is marked for auto-closure by the GitHub Actions bot. label Apr 1, 2023
@github-actions
Copy link

github-actions bot commented May 3, 2023

This issue was closed due to inactivity for 395 days.

@github-actions github-actions bot added the CLOSED_DUE_TO_INACTIVITY Issue or PR has been closed by the GitHub Actions bot due to inactivity. label May 3, 2023
@github-actions github-actions bot closed this as completed May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLOSED_DUE_TO_INACTIVITY Issue or PR has been closed by the GitHub Actions bot due to inactivity. MARKED_FOR_CLOSURE Issue or PR is marked for auto-closure by the GitHub Actions bot. pkg: Kokkos type: bug The primary issue is a bug in Trilinos code or tests
Projects
None yet
Development

No branches or pull requests

2 participants