Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature pam tty #224

Merged
merged 6 commits into from
Apr 18, 2023
Merged

Feature pam tty #224

merged 6 commits into from
Apr 18, 2023

Conversation

squell
Copy link
Member

@squell squell commented Apr 17, 2023

Closing #223; note: this builds on #221, that should be reviewed and merged first.

Also, #193 should be merged first, and will give two easily solved merge conflicts.

@squell squell linked an issue Apr 17, 2023 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Apr 17, 2023

Codecov Report

Patch coverage: 34.88% and project coverage change: -0.11 ⚠️

Comparison is base (483a094) 76.58% compared to head (df448af) 76.48%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #224      +/-   ##
==========================================
- Coverage   76.58%   76.48%   -0.11%     
==========================================
  Files          37       37              
  Lines        4609     4657      +48     
==========================================
+ Hits         3530     3562      +32     
- Misses       1079     1095      +16     
Impacted Files Coverage Δ
lib/sudo-pam/src/lib.rs 0.34% <0.00%> (ø)
sudo/src/pam.rs 0.00% <0.00%> (ø)
lib/sudo-pam/src/converse.rs 85.59% <15.78%> (+0.36%) ⬆️
lib/sudo-pam/src/rpassword.rs 34.06% <40.32%> (+34.06%) ⬆️
lib/sudo-common/src/context.rs 94.73% <100.00%> (+0.14%) ⬆️
lib/sudo-pam/src/securemem.rs 98.38% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@squell squell mentioned this pull request Apr 17, 2023
@squell squell marked this pull request as ready for review April 17, 2023 17:12
@rnijveld rnijveld added this pull request to the merge queue Apr 18, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 18, 2023
@rnijveld rnijveld added this pull request to the merge queue Apr 18, 2023
Merged via the queue into main with commit 9490dba Apr 18, 2023
@squell squell deleted the feature-pam-tty branch April 18, 2023 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support -S flag
2 participants