Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Electron to latest 11.x #3164

Closed
prusnak opened this issue Dec 9, 2020 · 4 comments · Fixed by #3187
Closed

Update Electron to latest 11.x #3164

prusnak opened this issue Dec 9, 2020 · 4 comments · Fixed by #3187

Comments

@prusnak
Copy link
Member

prusnak commented Dec 9, 2020

Electron 11.0.1 blocks Rosetta, because it used to crash. This has been fixed later and reverted in electron/electron#26568 - since Electron 11.0.2 can run on Rosetta. If we want to support Apple M1 devices, we need to update Electron to 11.0.2 or later.
@keraf keraf self-assigned this Dec 9, 2020
@prusnak prusnak mentioned this issue Dec 12, 2020
Closed
10 tasks
@prusnak prusnak changed the title Update Electron to latest (11.0.4 atm) Update Electron to latest (11.1.0 atm) Dec 14, 2020
@prusnak prusnak mentioned this issue Dec 15, 2020
Merged
@prusnak
Copy link
Member Author

prusnak commented Dec 15, 2020

Fix in #3187

@prusnak prusnak changed the title Update Electron to latest (11.1.0 atm) Update Electron to latest Dec 26, 2020
@prusnak prusnak changed the title Update Electron to latest Update Electron to latest 11.x Dec 26, 2020
@bosomt
Copy link
Contributor

bosomt commented Jan 4, 2021

@prusnak is there anything that can be tested on our side ?

@prusnak
Copy link
Member Author

prusnak commented Jan 4, 2021

Not particularly. It will be tested in full round of testing.

@bosomt
Copy link
Contributor

bosomt commented Jan 27, 2021

QA OK

Info:

Suite version: desktop 21.1.0 (93c2576)
OS: Linux x86_64
Screen: 1920x1080
Device: model One 1.9.3 regular

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(suite-desktop): update electron to 11.1.1 trezor/trezor-suite
3 participants
@prusnak @keraf @bosomt