Remove Check-related action buttons from Host Details page #1973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamie-suse
changed the title
arbulu89
reviewed
Nov 2, 2023
There was a problem hiding this comment.
@jamie-suse Wouldn't be better to add some if condition to remove the buttons but keep the code?
I mean, at some point, we want this logic present, and now that you removed, it will be more work to put it back hehe
|
@arbulu89 @jamie-suse had my green light because ATM we are just one click away from reverting this 😅 |
Strange strategy, but alright hehe |
dottorblaster
added a commit
that referenced
this pull request
Nov 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After the implementation of PR #1959, it was decided that as no Host Checks are currently available, the presence of the Check-related action buttons would be confusing to the user.
For example, if no Checks are available, the user can still click the Check Selection button to be taken to the Check Settings page. However as there are no Checks available, the UI displays a message to the user that the Checks Catalog is empty and a button to try again. This can be a confusing UX flow.
This change removes the Check-related action buttons from the UI in the Host Details page to make the UI easier to understand.
How was this tested?
Removed the tests checking for the presence of the checks-actions buttons