Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"cloudadmin" set as default as connection settings user in azure #419

Closed
arbulu89 opened this issue Apr 25, 2022 · 0 comments · Fixed by #430
Closed

"cloudadmin" set as default as connection settings user in azure #419

arbulu89 opened this issue Apr 25, 2022 · 0 comments · Fixed by #430
Labels
bug Something isn't working

Comments

@arbulu89
Copy link
Contributor

arbulu89 commented Apr 25, 2022 •
edited
Loading

The cloudadmin value is hardcoded for azure, which is wrong (this is a name we use in our team, nothing else).

We can get the default OS user from the cloud discovery data.

https://github.com/trento-project/web/blob/main/lib/trento/application/usecases/clusters/clusters.ex#L116

The needed data is coming in the cloud_discovery, at Metadata/compute/osProfile/adminUserName
@arbulu89 arbulu89 added the bug Something isn't working label Apr 25, 2022
@fabriziosestito fabriziosestito mentioned this issue Apr 26, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Discover azure admin user trento-project/web
1 participant
@arbulu89