Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add read_model suffix to read model tables #201

Closed
fabriziosestito opened this issue Mar 18, 2022 · 1 comment
Closed

Add read_model suffix to read model tables #201

fabriziosestito opened this issue Mar 18, 2022 · 1 comment

Comments

@fabriziosestito
Copy link
Member

..for the sake of clarity

@rtorrero
Copy link
Contributor

I started playing a bit with this idea and it turned into a bit of a mess when we reach associations:

When updating e.g. sap_system_read_model.ex, if we don't alter the

has_many :application_instances, ApplicationInstanceReadModel,

line, the tests complain:

** (ArgumentError) schema Trento.SapSystemReadModel does not have association :application_instances_read_model

If we have to change the has_many and also add the suffix there, we lose a bit of readability. After a quick chat with @fabriziosestito we agreed to close this one as WONTFIX for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants