Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add eslint to 'make check' #341

Open
4 tasks
trentm opened this issue Jan 28, 2016 · 0 comments
Open
4 tasks

add eslint to 'make check' #341

trentm opened this issue Jan 28, 2016 · 0 comments

Comments

@trentm
Copy link
Owner

trentm commented Jan 28, 2016

Linting is a good thing. Bunyan should be doing that. I've been using javascriptlint in a lot of work projects, but a friend has had good luck with eslint. Let's try that. If that is working well, we might just replace current jsstyle usage with that.

  • get starter eslint config from josh and a 'make check-eslint' in place
  • separate lint and style config files and check those separately: make check-eslint-lint and make check-eslint-style
  • refine the config files to a style I like (hopefully quite similar to what josh has already
  • hook it in to make check
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant